docs: Document users in e2e-security demo #49
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can not approve my own PR, but your stuff looks good @soenkeliebau |
|
As discussed in the daily, added some more information to the readme: @lfrancke |
soenkeliebau
previously approved these changes
May 29, 2024
lfrancke
requested changes
May 31, 2024
There was a problem hiding this comment.
I'm afraid I'm not happy just yet :(
From an accessibility standpoint there is a lot of data "hidden" in the images.
Can we at least get a rough written summary as for the other demos?
They have an Overview section that lists at least the tools that are deployed and some additional information.
I'm fine with not replicating everything that is in the image but at least a short description.
See the anomaly one for example.
"This demo will [....] You can see the [...]."
…ssibility reasons.
|
LGTM, many thanks @soenkeliebau! |
lfrancke
reviewed
Jun 26, 2024
lfrancke
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.